Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imgpkg: init at 0.43.1 #336558

Merged
merged 2 commits into from
Sep 23, 2024
Merged

imgpkg: init at 0.43.1 #336558

merged 2 commits into from
Sep 23, 2024

Conversation

BenChand
Copy link
Contributor

@BenChand BenChand commented Aug 22, 2024 •
edited
Loading

Description of changes

Added a package.nix for imgpkg

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@BenChand BenChand mentioned this pull request Aug 22, 2024
Closed
@BenChand BenChand changed the title imgpkg: init at 0.43.0 imgpkg: init at 0.42.1 Aug 22, 2024
@BenChand
Copy link
Contributor Author

Downgraded to 0.42.1 as 0.43.0 uses go >= 1.22.5 which buildGoModule isn't up to yet

@BenChand BenChand marked this pull request as ready for review August 23, 2024 09:41
SigmaSquadron
SigmaSquadron reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits based on the Commit Guidelines.

pkgs/by-name/im/imgpkg/package.nix Show resolved Hide resolved
pkgs/by-name/im/imgpkg/package.nix Show resolved Hide resolved
SigmaSquadron
SigmaSquadron approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, but please squash the commits to follow the Committing Guidelines.

@BenChand BenChand force-pushed the add-imgpkg branch 2 times, most recently from fd6a186 to 5278e7c Compare September 23, 2024 11:45
@BenChand BenChand changed the title imgpkg: init at 0.42.1 imgpkg: init at 0.43.1 Sep 23, 2024
@BenChand
Copy link
Contributor Author

Updated to imgpkg 0.43.1 as buildGoModule now supports that version of go

SigmaSquadron
SigmaSquadron approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval maintained.

@BenChand
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@BenChand merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/

Aleksanaa
Aleksanaa approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one more thing. Please split into two commits:

  1. maintainers: add benchand
  2. imgpkg: init at 0.43.1

@BenChand
Copy link
Contributor Author

Yeah that makes sense actually, will do

@BenChand
Copy link
Contributor Author

#343979

@Aleksanaa
Copy link
Member

Not splitting PRs, just commits in one PR

@Aleksanaa Aleksanaa merged commit 595d042 into NixOS:master Sep 23, 2024
27 of 28 checks passed
@BenChand BenChand deleted the add-imgpkg branch September 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 2 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenChand @Aleksanaa @SuperSandro2000 @SigmaSquadron