pid-fan-controller: init at 0.1.1 #336849
Open
+226
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimward
force-pushed
the
pid-fan-controller
branch
from
3af0028
to
875018c
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
875018c
to
a7e9668
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4559 |
phaer
reviewed
Sep 16, 2024
zimward
force-pushed
the
pid-fan-controller
branch
from
a7e9668
to
4137528
Compare
| heat_srcs = lib.mkOption { | ||
| type = lib.types.listOf (lib.types.submodule heatSource); | ||
| description = "list of heat sources"; | ||
| example = '' |
There was a problem hiding this comment.
The example is likely a big to big to properly render on search.nixos.org.
There was a problem hiding this comment.
I just halved the length of the example. Is there some example of the limits search.nixos.org is able to display?
There was a problem hiding this comment.
wdym? Yeah, it's a bit big, but nixos-search and the manual should be fine with it.
zimward
force-pushed
the
pid-fan-controller
branch
from
4137528
to
2f41247
Compare
zimward
force-pushed
the
pid-fan-controller
branch
3 times, most recently
from
73e7806
to
3a6a475
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
3a6a475
to
15e0150
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
15e0150
to
c07f3a2
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
c07f3a2
to
fc855c7
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
fc855c7
to
dbcd6f0
Compare
zimward
force-pushed
the
pid-fan-controller
branch
from
dbcd6f0
to
210aa64
Compare
SigmaSquadron
approved these changes
Sep 23, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pid-fan-controller is a (as the name implies) a fan controller using a PID control loop for Linux.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.