Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.scalene: 1.5.43.2 -> 1.5.44.1 #337099

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Aug 24, 2024

Description of changes

  1. Update to support setuptools >= 71. Fixes Build failure: python312Packages.scalene #335882
  2. Switch to a source build from a pypi build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec sarahec changed the title python3Packages.scalene: 1.5.34.2 -> 1.5.44.1 python3Packages.scalene: 1.5.43.2 -> 1.5.44.1 Aug 24, 2024
@sarahec sarahec added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Aug 24, 2024
@sarahec sarahec requested a review from bcdarwin August 24, 2024 22:46
@sarahec sarahec force-pushed the scalene-src-build branch from 9770945 to 35e5993 Compare August 25, 2024 01:50
@sarahec sarahec force-pushed the scalene-src-build branch from 35e5993 to c6b45b1 Compare August 25, 2024 02:02
@sarahec
Copy link
Contributor Author

sarahec commented Aug 25, 2024

Had a test failing intermittently due to a race condition accessing a socket. Failed more often on Darwin. Went ahead and disabled it.

@sarahec
Copy link
Contributor Author

sarahec commented Aug 25, 2024

Result of nixpkgs-review pr 337099 run on aarch64-darwin 1

4 packages built:
  • python311Packages.scalene
  • python311Packages.scalene.dist
  • scalene (python312Packages.scalene)
  • scalene.dist (python312Packages.scalene.dist)

@sarahec
Copy link
Contributor Author

sarahec commented Aug 25, 2024

Result of nixpkgs-review pr 337099 run on x86_64-linux 1

4 packages built:
  • python311Packages.scalene
  • python311Packages.scalene.dist
  • scalene (python312Packages.scalene)
  • scalene.dist (python312Packages.scalene.dist)

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpletz fpletz merged commit 428161d into NixOS:master Aug 25, 2024
22 checks passed
@sarahec sarahec deleted the scalene-src-build branch August 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.scalene
2 participants