-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.05] pnpm{,_8,_9,.fetchDeps}: init #337344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit 4549773)
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit 53af969)
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit 74f5ff7)
This script allows users to reuse the cached dependencies outside of derivations. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net> (cherry picked from commit 728d482)
(cherry picked from commit 711884c)
(cherry picked from commit c704c02)
(cherry picked from commit 6ff6c42)
(cherry picked from commit b331e60)
(cherry picked from commit 49d9dda)
(cherry picked from commit 7a1cd1f)
(cherry picked from commit 7affedd)
(cherry picked from commit a04915f)
(cherry picked from commit 1d8ea76)
(cherry picked from commit 27424c4)
Co-authored-by: Niklas Korz <niklas@niklaskorz.de> (cherry picked from commit 7eaa7e8)
…nfiguration commands Solves NixOS#316908 (cherry picked from commit 875c9f0)
(cherry picked from commit 57c288b)
emilazy
force-pushed
the
push-txtsrpvmkukn
branch
from
August 25, 2024 21:37
d77a5f5
to
83069d0
Compare
1 task
SuperSandro2000
approved these changes
Aug 25, 2024
gepbird
approved these changes
Aug 26, 2024
I’ve confirmed that #337312 builds on top of this; merging. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Manual backport of #290715, #319042, #320124, #317739, #322753, #325837, #323493, and #332966, omitting the changes that touched existing packages. Brings
pnpm.fetchDeps
support to 24.05 to be used for backports. I’ve verified that the port ofkiwitalk
from the original PR compiles on 24.05 after these commits, so the functionality works.Since this doesn’t change any existing packages and just adds new functionality it should be fine to backport, but it is pretty heavy. The motivating example is #337312, where a package was ported to a non‐EOL Electron but switched to
pnpm.fetchDeps
in the process.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.