Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove srgom #337369

Closed
wants to merge 2 commits into from
Closed

treewide: remove srgom #337369

wants to merge 2 commits into from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Aug 26, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review August 26, 2024 00:37
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Aug 26, 2024

Pinging @SRGOM

#290642

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Aug 26, 2024
@dotlambda
Copy link
Member

Should they also be removed from the maintainer list?

@AndersonTorres
Copy link
Member Author

I prefer to do this in a future batch.

@doronbehar
Copy link
Contributor

I prefer to do this in a future batch.

It makes sense a bit more to me to do it per maintainer. Other then that, this is good to go. Let's give @SRGOM a few days to respond. If days pass, cc me to merge this if I forget.

@AndersonTorres
Copy link
Member Author

Sometimes some packages are maintained by multiple silent maintainers. It can create some strange dependency trees.

Other times some packages are being modified on Staging.

Further, some people want to adopt some packages, and I prefer to detach them so that they cam be adopted independently.

Because of this and other minor annoying things, I prefer to delete entries in maintainers set a bit later.

@bendlas
Copy link
Contributor

bendlas commented Aug 26, 2024

Closing these removal PRs, since they are not grounded within community consensus. See #337478 (comment)

@SRGOM be sure that we value your involvement and any time you may have to spare, helping with the packages you're maintaining and others as well.

@SigmaSquadron SigmaSquadron added the 2.status: invalid "This doesn't seem right": Issues or PRs that are unintelligible label Aug 26, 2024
@bendlas bendlas closed this Aug 26, 2024
@AndersonTorres AndersonTorres deleted the remove-srgom branch August 26, 2024 20:16
@SuperSandro2000
Copy link
Member

That account has been inactive for 4 years. It can be removed with no bad feelings.

@bendlas
Copy link
Contributor

bendlas commented Aug 28, 2024

That account has been inactive for 4 years. It can be removed with no bad feelings.

The other PR got a bit hectic, so one could be forgiven for not reading all the way through. So again here in simple terms:

I'm not opposed to getting stale maintainers out. I am opposed to doing it the way it's being done in these PRs.

More on the new PR you opened, but the gist is: At that rate you could have just re-opened this one ...

@SuperSandro2000
Copy link
Member

GitHub doesn't allow me to reopen this PR, so I opened a new one.

@superherointj
Copy link
Contributor

I'm not opposed to getting stale maintainers out.

Okay...

I am opposed to doing it the way it's being done in these PRs.

You are only opposed to the wording of the description of the pull request, correct?

Since the PR content was right then. You should have never closed all these PRs, without asking first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: invalid "This doesn't seem right": Issues or PRs that are unintelligible 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants