-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scotch: 7.0.4 -> 7.0.5 #337565
scotch: 7.0.4 -> 7.0.5 #337565
Conversation
Result of 35 packages built:
|
Result of 28 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not run nixpkgs-review as it seems that one of the packages to build makes the load of my laptop go weird and triggs oom-killer
Anyway, the commits LGTM
Thanks for the review @bzizou ! @MatthewCroughan : Is your issue with the CMake packaging of this project fixed ? |
Description of changes
Changes notes:
While here, separate outputs, as this package has 31 executables which look like tests. It might also help @MatthewCroughan who has issues with
include/metis.h
overriding the one from metis → putting it in in another output might help. I'll report this upstream though.And also, shared libs.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.