Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scotch: 7.0.4 -> 7.0.5 #337565

Merged
merged 4 commits into from
Sep 13, 2024
Merged

scotch: 7.0.4 -> 7.0.5 #337565

merged 4 commits into from
Sep 13, 2024

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Aug 26, 2024

Description of changes

Changes notes:

This revision is essentially a bugfix release, but it also provides new features:

The installation of Scotch on Windows-like environments has been improved.
Native Windows threads are now supported.
The CMake compilation chain is now fully mature.
New routines have been added, to run the upcoming "ScotchPy" Python interface for Scotch and PT-Scotch.

While here, separate outputs, as this package has 31 executables which look like tests. It might also help @MatthewCroughan who has issues with include/metis.h overriding the one from metis → putting it in in another output might help. I'll report this upstream though.

And also, shared libs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nim65s
Copy link
Contributor Author

nim65s commented Aug 27, 2024

Result of nixpkgs-review pr 337565 run on x86_64-linux 1

35 packages built:
  • bonmin
  • casadi
  • crocoddyl
  • ipopt
  • mumps
  • openturns
  • pagmo2
  • pinocchio
  • python311Packages.aerosandbox
  • python311Packages.aerosandbox.dist
  • python311Packages.casadi
  • python311Packages.crocoddyl
  • python311Packages.example-robot-data
  • python311Packages.fenics
  • python311Packages.fenics.dist
  • python311Packages.neuralfoil
  • python311Packages.neuralfoil.dist
  • python311Packages.openturns
  • python311Packages.pinocchio
  • python311Packages.pygmo
  • python312Packages.aerosandbox
  • python312Packages.aerosandbox.dist
  • python312Packages.casadi
  • python312Packages.crocoddyl
  • python312Packages.example-robot-data
  • python312Packages.fenics
  • python312Packages.fenics.dist
  • python312Packages.neuralfoil
  • python312Packages.neuralfoil.dist
  • python312Packages.openturns
  • python312Packages.pinocchio
  • python312Packages.pygmo
  • scotch
  • scotch.bin
  • scotch.dev

@nim65s
Copy link
Contributor Author

nim65s commented Aug 28, 2024

Result of nixpkgs-review pr 337565 run on aarch64-darwin 1

28 packages built:
  • bonmin
  • casadi
  • crocoddyl
  • ipopt
  • openturns
  • pinocchio
  • python311Packages.aerosandbox
  • python311Packages.aerosandbox.dist
  • python311Packages.casadi
  • python311Packages.crocoddyl
  • python311Packages.example-robot-data
  • python311Packages.fenics
  • python311Packages.fenics.dist
  • python311Packages.neuralfoil
  • python311Packages.neuralfoil.dist
  • python311Packages.openturns
  • python311Packages.pinocchio
  • python312Packages.aerosandbox
  • python312Packages.aerosandbox.dist
  • python312Packages.casadi
  • python312Packages.crocoddyl
  • python312Packages.example-robot-data
  • python312Packages.fenics
  • python312Packages.fenics.dist
  • python312Packages.neuralfoil
  • python312Packages.neuralfoil.dist
  • python312Packages.openturns
  • python312Packages.pinocchio

Copy link
Contributor

@bzizou bzizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not run nixpkgs-review as it seems that one of the packages to build makes the load of my laptop go weird and triggs oom-killer
Anyway, the commits LGTM

@nim65s
Copy link
Contributor Author

nim65s commented Aug 30, 2024

Thanks for the review @bzizou !
It is OK for me too.

@MatthewCroughan : Is your issue with the CMake packaging of this project fixed ?

@nim65s nim65s marked this pull request as ready for review September 4, 2024 15:52
@pbsds pbsds merged commit 1d28f48 into NixOS:master Sep 13, 2024
46 checks passed
@nim65s nim65s deleted the scotch branch September 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants