Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color transformation language init #338697

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

paperdigits
Copy link
Contributor

@paperdigits paperdigits commented Aug 31, 2024

Description of changes

Add CTL capability to ART. This involved packaging CTL (color-transform-language) and aces-container.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/ac/aces_container/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/color-transformation-language/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/ac/aces_container/default.nix Outdated Show resolved Hide resolved
@paperdigits paperdigits force-pushed the color-transformation-language-init branch from 17d998a to 985e8ca Compare September 1, 2024 19:05
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Sep 1, 2024
lib/licenses.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/color-transformation-language/package.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/art/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/art/package.nix Outdated Show resolved Hide resolved
@paperdigits paperdigits force-pushed the color-transformation-language-init branch 3 times, most recently from 0ac0b64 to f072933 Compare September 1, 2024 21:16
@paperdigits
Copy link
Contributor Author

@eclairevoyant I don't understand what I'm supposed to do with that check failure.

@eclairevoyant
Copy link
Contributor

@eclairevoyant I don't understand what I'm supposed to do with that check failure.

#338697 (comment)

@paperdigits
Copy link
Contributor Author

@eclairevoyant so I just don't need to reference the packages at all in all-packages.nix?

@eclairevoyant
Copy link
Contributor

The whole point of pkgs/by-name is to not have to add an entry in all-packages.nix, yes.

@paperdigits
Copy link
Contributor Author

@ofborg build art

@paperdigits
Copy link
Contributor Author

paperdigits commented Sep 11, 2024

@eclairevoyant I made the git history a lot cleaner and I've made all requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants