Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdal: 2.7.2 -> 2.8.0 #340015

Merged
merged 2 commits into from
Sep 7, 2024
Merged

pdal: 2.7.2 -> 2.8.0 #340015

merged 2 commits into from
Sep 7, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Sep 6, 2024

Description of changes

Update PDAL to the latest version.

Release notes:
https://github.com/PDAL/PDAL/releases/tag/2.8.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 6, 2024
@imincik
Copy link
Contributor Author

imincik commented Sep 6, 2024

Result of nixpkgs-review pr 340015 run on x86_64-linux 1

5 packages built:
  • entwine
  • grass
  • pdal
  • qgis
  • qgis-ltr

@sikmir
Copy link
Member

sikmir commented Sep 6, 2024

Result of nixpkgs-review pr -P qgis -P qgis-ltr 340015 run on x86_64-darwin 1

1 package failed to build:
  • grass
1 package built:
  • pdal

grass is broken on darwin on master:

grass> patching file db/drivers/mysql/db.c
grass> Hunk #1 FAILED at 52.
grass> 1 out of 1 hunk FAILED -- saving rejects to file db/drivers/mysql/db.c.rej

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 6, 2024
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; untested.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 7, 2024
Co-authored-by: Nikolay Korotkiy <sikmir@disroot.org>
@ofborg ofborg bot requested review from l0b0 and sikmir September 7, 2024 17:43
@sikmir sikmir merged commit daabe57 into NixOS:master Sep 7, 2024
22 of 26 checks passed
@imincik
Copy link
Contributor Author

imincik commented Sep 8, 2024

grass is broken on darwin on master:

grass> patching file db/drivers/mysql/db.c
grass> Hunk #1 FAILED at 52.
grass> 1 out of 1 hunk FAILED -- saving rejects to file db/drivers/mysql/db.c.rej

Thanks, issue created #340475

imincik added a commit to imincik/geospatial-nix that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants