tanka: 0.27.1 -> 0.28.0 #340060
Merged
tanka: 0.27.1 -> 0.28.0 #340060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
nevivurn
suggested changes
Sep 12, 2024
There was a problem hiding this comment.
Can you also bump the tanka version while we're at it?
The upstream change only landed around 0.28.0, makes little sense to add fixes for some version we have not packaged yet. I can at least confirm that the build is broken as you explained on 0.28.1: r-ryantm logs.
theSuess
force-pushed
the
tanka-disable-gowork
branch
from
c21667d
to
c779b2e
Compare
|
I've now also bumped the version to |
nevivurn
approved these changes
Sep 17, 2024
nevivurn
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With the addition of a
go.workfile in grafana/tanka#1040, newer versions were no longer able to be built. Thego.workfile is only needed for acceptance tests, soGOWORK=offcan safely be set during builds.Previous changes of a similar nature: #301928
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.