bitwarden-cli: Add xcodebuild to darwin build input. #340138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
|
@dotlambda Are you able to review this pull request? |
khaneliman
reviewed
Sep 29, 2024
| @@ -34,6 +34,7 @@ buildNpmPackage rec { | |||
| ] ++ lib.optionals stdenv.isDarwin [ | |||
| cctools | |||
| xcbuild.xcrun | |||
| xcbuild.xcodebuild | |||
There was a problem hiding this comment.
Suggested change
| xcbuild.xcodebuild | |
| xcodebuild |
There was a problem hiding this comment.
error: attribute 'xcodebuild' missing
at /ofborg/checkout/1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-0/pkgs/by-name/bi/bitwarden-cli/package.nix:37:5:
36| xcbuild.xcrun
37| xcbuild.xcodebuild
| ^
38| ];
There was a problem hiding this comment.
@khaneliman With the suggested change there is an error:
error: undefined variable 'xcodebuild'
at /home/runner/work/nixpkgs/nixpkgs/pkgs/by-name/bi/bitwarden-cli/package.nix:38:5:
37| xcbuild.xcrun
38| xcodebuild
| ^
39| ];
There was a problem hiding this comment.
Would still needed to be added to inputs.
sixtysecrun
force-pushed
the
fix-bitwarden-darwin-build
branch
3 times, most recently
from
bf102eb to
0754cbe
Compare
Fixes the error: npm error FileNotFoundError: [Errno 2] No such file or directory: 'xcodebuild'
sixtysecrun
force-pushed
the
fix-bitwarden-darwin-build
branch
from
0754cbe to
562e663
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
13 tasks
|
This seems to no longer be necessary with #350601, where the build fails for a different reason. |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add
xcodebuildto darwin build input. It fixes the error:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.