Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap: remap cafkafk #343851

Merged
merged 1 commit into from
Sep 23, 2024
Merged

mailmap: remap cafkafk #343851

merged 1 commit into from
Sep 23, 2024

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Sep 23, 2024

Description of changes

I've managed to fill the git logs with several broken
identities (sorry). This makes sure that they all refer to a single,
accurate and reachable one.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I've managed to fill the git logs with several broken
identities (sorry). This makes sure that they all refer to a single,
accurate and reachable one.

Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to find the github noreply email used anywhere in the commit history. Is it for future proofing?

@cafkafk
Copy link
Member Author

cafkafk commented Sep 23, 2024

I can't seem to find the github noreply email used anywhere in the commit history. Is it for future proofing?

Ohh, they are actually real, just pretty hidden. Can be found with e.g. git log --format="%H %ae" --all | rg --fixed-strings "89321978"

@cafkafk cafkafk merged commit 71ade9d into NixOS:master Sep 23, 2024
23 checks passed
@cafkafk cafkafk deleted the fix-cafkafk-mailcap branch September 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants