gomanagedocker: init at 1.4 #347300
Merged
gomanagedocker: init at 1.4 #347300
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1dugh
reviewed
Oct 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
genga898
force-pushed
the
gomanagedocker
branch
4 times, most recently
from
9f108da
to
b1e4ed8
Compare
genga898
force-pushed
the
gomanagedocker
branch
from
b1e4ed8
to
454dd14
Compare
SigmaSquadron
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Excellent work; thank you for addressing this so quickly! Here are some optional recommendations for your continued maintenance of this derivation: (for future PRs)
- Add the
passthru.updateScript = nix-update-script { };attribute, so @r-ryantm can reliably pick up updates to this package. The bot will create update pull requests for you, and as a maintainer, you'll be able to commit those automated updates into the repo by calling the @NixOS/nixpkgs-merge-bot. - Add automated testing for the package. A low-hanging fruit is the trivial
versioncheckhook, which tests that you're actually building the right version. You may also want to build a TUI package testing suite likenano's, or a full on NixOS virtual machine, as described in the manual.
Result of nixpkgs-review pr 347300 run on x86_64-linux 1
1 package built:
- gomanagedocker
genga898
force-pushed
the
gomanagedocker
branch
from
f8a163b
to
4a466a7
Compare
|
If nix-update-script works without arguments, you might not need to add it to make the update work to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.