Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bear: reformat, fix build failure #348399

Merged
merged 2 commits into from
Oct 14, 2024
Merged

bear: reformat, fix build failure #348399

merged 2 commits into from
Oct 14, 2024

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Oct 14, 2024

Downgrades protobuf to v25 as it seems that bear can not be built with v28 yet. The protobuf attribute was upgraded from v25 to v28 in #338885.

Closes #348397.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jchv
Copy link
Contributor Author

jchv commented Oct 14, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348399


x86_64-linux

✅ 1 package built:
  • bear

@jchv
Copy link
Contributor Author

jchv commented Oct 14, 2024

Result of nixpkgs-review pr 348399 run on aarch64-darwin 1

1 package built:
  • bear

@ofborg ofborg bot requested a review from DieracDelta October 14, 2024 02:54
@Aleksanaa Aleksanaa merged commit b6e9fba into NixOS:master Oct 14, 2024
46 of 47 checks passed
@DieracDelta
Copy link
Member

Thanks for chasing this down! Any chance you tried building with a more recent release of bear? It looks like we're a few minor versions behind now. I wonder if they fixed this in a more recent version.

@jchv
Copy link
Contributor Author

jchv commented Oct 14, 2024

I can't take a look immediately, but either way I reckon getting it to work with v28 upstream will be fairly easy. I wouldn't be surprised if it didn't yet only because protobuf tends to be pretty out-of-date on Linux in my experience, I don't think protobuf C++ really has any guaranteed-to-be-stable APIs across versions so it's always painful to deal with. Hopefully some day there will be a better way to catch these sorts of trivial build failures easier...

@jchv jchv deleted the fix/bear branch October 14, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: bear
3 participants