Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/systems: musl "ABI"s, examples #34861

Merged
merged 2 commits into from
Feb 12, 2018
Merged

lib/systems: musl "ABI"s, examples #34861

merged 2 commits into from
Feb 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 11, 2018

Pull out the changes to lib.systems from the musl PR (#34645).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
lib/systems: musl, libc predicates
2dfee94 
Note this doesn't actually provide musl support yet,
just improves our "system" code to understand
musl-based triples and non-glibc linux configurations.
@dtzWill
Drop "isGlibc", but keep isMusl.
f090bbb 
gnu "abi" doesn't mean glibc (mingw, apparently).
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Feb 11, 2018
@Ericson2314 Ericson2314 merged commit cd121fd into NixOS:staging Feb 12, 2018
@Ericson2314
Copy link
Member

Ah did on phone so didn't see it's going to staging.

@Ericson2314
Copy link
Member

I'll send to both

@dtzWill dtzWill mentioned this pull request Feb 12, 2018
Merged
3 tasks
@dtzWill dtzWill deleted the feature/musl-lib branch February 12, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzWill @Ericson2314 @fpletz @GrahamcOfBorg