Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.opentelemetry-proto: fix protobuf version #348738

Closed
wants to merge 1 commit into from
Closed

python312Packages.opentelemetry-proto: fix protobuf version #348738

wants to merge 1 commit into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Oct 15, 2024 •
edited
Loading

opentelemetry-proto requires protobuf <5.0 and >=3.19, therefore setting the protobuf dependency to protobuf4.

Issue introduced in #338885

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol force-pushed the push-oxrvorwlqvtw branch 2 times, most recently from c6fae6d to d7a78f4 Compare October 15, 2024 09:22
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348738

x86_64-linux

❌ 30 packages failed to build:
  • open-webui
  • open-webui.dist
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-cli
  • python311Packages.llama-index-cli.dist
  • python311Packages.llama-index-vector-stores-chroma
  • python311Packages.llama-index-vector-stores-chroma.dist
  • python311Packages.llama-index.dist
  • python311Packages.opentelemetry-exporter-otlp
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-http
  • python311Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python311Packages.opentelemetry-exporter-otlp.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.opentelemetry-exporter-otlp
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-http
  • python312Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python312Packages.opentelemetry-exporter-otlp.dist
✅ 8 packages built:
  • python311Packages.opentelemetry-exporter-otlp-proto-common
  • python311Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python311Packages.opentelemetry-proto
  • python311Packages.opentelemetry-proto.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-common
  • python312Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python312Packages.opentelemetry-proto
  • python312Packages.opentelemetry-proto.dist

aarch64-linux

⏩ 18 packages marked as broken and skipped:
  • open-webui
  • open-webui.dist
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-cli
  • python311Packages.llama-index-cli.dist
  • python311Packages.llama-index-vector-stores-chroma
  • python311Packages.llama-index-vector-stores-chroma.dist
  • python311Packages.llama-index.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
❌ 12 packages failed to build:
  • python311Packages.opentelemetry-exporter-otlp
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-http
  • python311Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python311Packages.opentelemetry-exporter-otlp.dist
  • python312Packages.opentelemetry-exporter-otlp
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-http
  • python312Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python312Packages.opentelemetry-exporter-otlp.dist
✅ 8 packages built:
  • python311Packages.opentelemetry-exporter-otlp-proto-common
  • python311Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python311Packages.opentelemetry-proto
  • python311Packages.opentelemetry-proto.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-common
  • python312Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python312Packages.opentelemetry-proto
  • python312Packages.opentelemetry-proto.dist

x86_64-darwin

⏩ 10 packages marked as broken and skipped:
  • open-webui
  • open-webui.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-cli
  • python311Packages.llama-index-cli.dist
  • python311Packages.llama-index-vector-stores-chroma
  • python311Packages.llama-index-vector-stores-chroma.dist
  • python311Packages.llama-index.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
❌ 20 packages failed to build:
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.opentelemetry-exporter-otlp
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-http
  • python311Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python311Packages.opentelemetry-exporter-otlp.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.opentelemetry-exporter-otlp
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-http
  • python312Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python312Packages.opentelemetry-exporter-otlp.dist
✅ 8 packages built:
  • python311Packages.opentelemetry-exporter-otlp-proto-common
  • python311Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python311Packages.opentelemetry-proto
  • python311Packages.opentelemetry-proto.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-common
  • python312Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python312Packages.opentelemetry-proto
  • python312Packages.opentelemetry-proto.dist

aarch64-darwin

⏩ 8 packages marked as broken and skipped:
  • python311Packages.llama-index
  • python311Packages.llama-index-cli
  • python311Packages.llama-index-cli.dist
  • python311Packages.llama-index-vector-stores-chroma
  • python311Packages.llama-index-vector-stores-chroma.dist
  • python311Packages.llama-index.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
❌ 22 packages failed to build:
  • open-webui
  • open-webui.dist
  • python311Packages.chromadb
  • python311Packages.chromadb.dist
  • python311Packages.langchain-chroma
  • python311Packages.langchain-chroma.dist
  • python311Packages.opentelemetry-exporter-otlp
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc
  • python311Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python311Packages.opentelemetry-exporter-otlp-proto-http
  • python311Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python311Packages.opentelemetry-exporter-otlp.dist
  • python312Packages.chromadb
  • python312Packages.chromadb.dist
  • python312Packages.langchain-chroma
  • python312Packages.langchain-chroma.dist
  • python312Packages.opentelemetry-exporter-otlp
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc
  • python312Packages.opentelemetry-exporter-otlp-proto-grpc.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-http
  • python312Packages.opentelemetry-exporter-otlp-proto-http.dist
  • python312Packages.opentelemetry-exporter-otlp.dist
✅ 8 packages built:
  • python311Packages.opentelemetry-exporter-otlp-proto-common
  • python311Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python311Packages.opentelemetry-proto
  • python311Packages.opentelemetry-proto.dist
  • python312Packages.opentelemetry-exporter-otlp-proto-common
  • python312Packages.opentelemetry-exporter-otlp-proto-common.dist
  • python312Packages.opentelemetry-proto
  • python312Packages.opentelemetry-proto.dist

@GaetanLepage
Copy link
Contributor 

Running phase: pythonCatchConflictsPhase
Found duplicated packages in closure for dependency 'protobuf':
  protobuf 5.28.2 (/nix/store/f3x1d3vk75d1vg31w1d4qpbynka6ywiv-python3.12-protobuf-5.28.2)
    dependency chain:
      this derivation: /nix/store/7lb3ck5mn43yrhjpi39xhkabc7fd7x66-python3.12-opentelemetry-exporter-otlp-proto-http-1.26.0
      ...depending on: /nix/store/dqis9l8wrgbgx9r8f7r971d37mh65z47-python3.12-googleapis-common-protos-1.63.1
      ...depending on: /nix/store/f3x1d3vk75d1vg31w1d4qpbynka6ywiv-python3.12-protobuf-5.28.2
  protobuf 4.25.4 (/nix/store/v2xzzd7nskyx2yz7xzyk50qvgl7bixyq-python3.12-protobuf-4.25.4)
    dependency chain:
      this derivation: /nix/store/7lb3ck5mn43yrhjpi39xhkabc7fd7x66-python3.12-opentelemetry-exporter-otlp-proto-http-1.26.0
      ...depending on: /nix/store/49c3vvmjiyp0pwvmsw6905kr4zcfs66c-python3.12-opentelemetry-exporter-otlp-proto-common-1.26.0
      ...depending on: /nix/store/immawqcr5rj35zqk4c19ss23ya2610dk-python3.12-opentelemetry-proto-1.26.0
      ...depending on: /nix/store/v2xzzd7nskyx2yz7xzyk50qvgl7bixyq-python3.12-protobuf-4.25.4

Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.

:')

@drupol
Copy link
Contributor Author

drupol commented Oct 15, 2024

Oh boy... what should we do to fix this?

@GaetanLepage
Copy link
Contributor

Oh boy... what should we do to fix this?

I asked chat gpt and he told me sudo apt install protobuf but I have not tried yet.

@natsukium
Copy link
Member

I haven't looked, but could you use this patch? open-telemetry/opentelemetry-python#4206

@drupol
python312Packages.opentelemetry-proto: fix protobuf version
cd72fbd 
It requires protobuf <5.0 and >=3.19, therefore setting
the `protobuf` dependency to `protobuf4`.
@drupol
Copy link
Contributor Author

drupol commented Oct 15, 2024

I haven't looked, but could you use this patch? open-telemetry/opentelemetry-python#4206

There's ~20 commits there, can I use the PR diff URL ? https://patch-diff.githubusercontent.com/raw/open-telemetry/opentelemetry-python/pull/4206.diff

@natsukium
Copy link
Member

We can use this commit since it has already been merged.
open-telemetry/opentelemetry-python@d1904b9

@drupol

This comment was marked as outdated.

Sign in to view
@Steinhagen
Copy link
Contributor

There is already a commit to fix this python issue in 'staging' right now: 090f644

@drupol
Copy link
Contributor Author

drupol commented Oct 15, 2024

Thanks... it's going to be fixed in 2 weeks then? Is there a way to fix this earlier?

@mweinelt
Copy link
Member

Sorry, no.

@mweinelt mweinelt removed their request for review October 15, 2024 18:01
@drupol
Copy link
Contributor Author

drupol commented Oct 15, 2024

Fair enough, closing this.

@drupol drupol closed this Oct 15, 2024
This was referenced Oct 17, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium requested changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@invokes-su invokes-su Awaiting requested review from invokes-su

@de11n de11n Awaiting requested review from de11n

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drupol @GaetanLepage @natsukium @Steinhagen @mweinelt