Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost1{75,77,78,79}: fix build #350658

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

paparodeo
Copy link
Contributor

condition a substituteInPlace only on boost 180 and above and add one substituteInPlace back to the only consumer, boost175.

updates change 90df0c3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

condition a substituteInPlace only on boost 180 and above and add one
substituteInPlace back to the only consumer, boost175.

updates change 90df0c3
@ofborg ofborg bot requested a review from ivan-tkatchev October 23, 2024 08:28
@K900 K900 merged commit 949b508 into NixOS:staging-next Oct 23, 2024
29 of 30 checks passed
@paparodeo paparodeo deleted the old-boost-fixes branch October 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants