Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

castxml: fix darwin build #350853

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Oct 24, 2024

clang on darwin adds an -isysroot flag which breaks the regular expressions used in a couple tests

https://hydra.nixos.org/build/276117682

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

clang on darwin adds an `-isysroot` flag which breaks the regular
expressions used in a couple tests
@paparodeo paparodeo force-pushed the castxml-ignore-tests branch from e911cd8 to 76d2941 Compare October 24, 2024 16:13
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those couple tests are doing really weird regexp matching on compiler flags so I think it’s fine to skip them on all platforms.

@emilazy emilazy merged commit e80a134 into NixOS:staging-next Oct 24, 2024
27 of 28 checks passed
@paparodeo paparodeo deleted the castxml-ignore-tests branch October 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants