Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vorbis-tools: fix darwin build #350890

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Oct 24, 2024

ld64 doesn't support linking with nested archives and as the nested archived isn't required to build leave it out.
https://hydra.nixos.org/build/276179684

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 24, 2024
ld64 doesn't support linking with nested archives and as the nested
archived isn't required to build leave it out.
@emilazy emilazy merged commit 8b4a343 into NixOS:staging-next Oct 24, 2024
10 of 11 checks passed
@paparodeo paparodeo deleted the vorbis-tools-fix branch October 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants