Restore linuxManualConfig as linux/kernel/manual-config.nix #35094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In a recent pull request (#34351) the definition of
buildLinux
changed fromlinux/kernel/manual-config.nix
tolinux/kernel/generic.nix
. SincelinuxManualConfig
is an alias ofbuildLinux
, this means thatlinuxManualConfig
now points tolinux/kernel/generic.nix
.I haven't examined the details of the work in this area, but it reads like a simple oversight. The documentation also doesn't seem to have a section on how to build a manually configured kernel. Is
linuxManualConfig
the intended way?Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)