system76-power: 1.2.1 -> 1.2.2

[ahoneybun]

What this does:

• Use HEDT fan curve for thelio-astra-a1

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[sjmonson]

LGTM I will try to give it a test later today.

[sjmonson]

Is it feasible to have upstream add a checksum to the sysfs-class dependency? Then we could drop this file.

[ahoneybun]

I thought the Cargo.lock file is for any Rust project?

[sjmonson]

No, if the Cargo.lock is inside the src tarball that is pulled then you just need to specify the hash of the file. See documentation and the previous version of this package:

nixpkgs/pkgs/by-name/sy/system76-power/package.nix

Line 17 in 76e0284

cargoHash = "sha256-Vps02ZRVmeOQ8jDFZJYAUb502MhqY+2YV2W1/9XGY+0=";

However, I am actually not sure which method is actually preferred between what we do now vs the cargoHash field.

[ahoneybun]

I'm not sure either, this is how it is for the COSMIC packages that I have seen and maintain so it seems fine.

[ahoneybun]

Upstream is open to it, I can make a PR or you can. Just let me know and I'll get it handled either way.

[alyssais]

I'm not sure either, this is how it is for the COSMIC packages that I have seen and maintain so it seems fine.

It is allowed, but definitely disfavoured.

[ahoneybun]

If I had the steps to add it to upstream I'd be happy to do that and make another PR to remove it from this package!

[alyssais]

A new release of sysfs-class probably needs to be published to crates.io, and then system76-power upstream needs to use that released version rather than a git dependency, and then Nixpkgs needs to be updated to that version of system76-power.

[alyssais]

One tiny thing. Otherwise looks fine.