gtk4: fix x64 darwin #351004
gtk4: fix x64 darwin #351004
Conversation
use 10.15 sdk to fix build and propagate the sdk and min sdk version (10.15)
paparodeo
force-pushed
the
gtk4-x86-darwin-fix
branch
from
dc564ca to
0d75f35
Compare
| ] ++ lib.optionals (stdenv.hostPlatform.isDarwin | ||
| && lib.versionOlder apple-sdk.version "10.15") [ | ||
| apple-sdk_10_15 |
There was a problem hiding this comment.
not sure if this logic is totally correct as it seems like a little hack to assume that the current sdk is apple-sdk cause it could be propagated by some other package or something.
but this still should be good enough as is limited to just x64 Darwin.
There was a problem hiding this comment.
It should be fine, since newer SDKs win: the only reason to conditionalize this is because apple-sdk_10_15 can fail to evaluate (on aarch64-darwin), which is safely covered by the case lib.versionOlder apple-sdk.version "10.15".
| @@ -165,6 +162,11 @@ stdenv.mkDerivation (finalAttrs: { | |||
| # Required for GSettings schemas at runtime. | |||
| # Will be picked up by wrapGAppsHook4. | |||
| gsettings-desktop-schemas | |||
| ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ | |||
| (darwinMinVersionHook "15.0") | |||
There was a problem hiding this comment.
wait a sec -- I wanted 10.15 here.
There was a problem hiding this comment.
Uh, whoops. Do you mind opening a PR to fix? Otherwise I’ll get to it tomorrow.
(Finally an aggressive macOS version support policy!)
use 10.15 sdk to fix build
https://hydra.nixos.org/build/276111373
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.