haskellPackages.password: use crypton, disable scrypt on non-x86 #351305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- crypton is maintained, contrary to cryptonite - since the Hackage scrypt package uses SSE2, we can't build it on non-x86 platforms (non x86_64 even probably). The best option is to disable the Scrypt module. To prevent cabal from pulling in scrypt in spite of that, we need to patch build-depends to respect the flag.
|
Confirmed to work on aarch64-linux and x86_64-linux. Darwin is difficult to test at the moment because we don't have any sort of cache from a Hydra jobset. |
maralorn
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
LGTM, but maybe @cdepillabout wants to have a quick glance.
wegank
added
the
12.approvals: 1
cdepillabout
approved these changes
Nov 2, 2024
cdepillabout
added a commit
to cdepillabout/password
that referenced
this pull request
Nov 8, 2024
See the following for more information: - NixOS/nixpkgs#351305 - #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently untested, waiting for cache to catch up.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.