Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mission-center: 0.6.1 -> 0.6.2 #351653

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 27, 2024

Things done

Requires rust 1.82. Let's wait until it reaches master.

Changelog: https://gitlab.com/mission-center-devs/mission-center/-/releases/v0.6.2

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351653


x86_64-linux

❌ 1 package failed to build:
  • mission-center

aarch64-linux

❌ 1 package failed to build:
  • mission-center

x86_64-darwin


aarch64-darwin

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 27, 2024
@GaetanLepage GaetanLepage marked this pull request as draft October 27, 2024 17:39
@JohnRTitor
Copy link
Contributor

Why not merge it in staging-next? #348827 should be fine in the current iteration.

@GaetanLepage GaetanLepage changed the base branch from master to staging-next October 29, 2024 13:45
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: policy discussion 6.topic: vim 6.topic: cinnamon Desktop environment 6.topic: vscode labels Oct 29, 2024
@GaetanLepage GaetanLepage marked this pull request as ready for review October 29, 2024 13:45
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor labels Oct 29, 2024
@GaetanLepage
Copy link
Contributor Author

Why not merge it in staging-next? #348827 should be fine in the current iteration.

Sure. I have just changed the base. It builds fine and works correctly on my system.
If you approve the PR, I will go ahead and merge it.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351653


x86_64-linux

✅ 1 package built:
  • mission-center

aarch64-linux

✅ 1 package built:
  • mission-center

x86_64-darwin


aarch64-darwin

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Oct 29, 2024
@JohnRTitor
Copy link
Contributor

JohnRTitor commented Oct 29, 2024

Omg, are my eyes deceiving me

This should go through staging 🙃

@GaetanLepage
Copy link
Contributor Author

Omg, are my eyes deceiving me

This should go through staging 🙃

Wait this is very weird... It's a leaf package, it shoudn't cause any rebuild.

@JohnRTitor
Copy link
Contributor

Diff is fine and checked the commit (just one, no issues happened when rebasing)

I'd just merge it and blame the error on Ofborg.

@JohnRTitor JohnRTitor added the ofborg-internal-error Ofborg encountered an error label Oct 29, 2024
@JohnRTitor JohnRTitor merged commit 0071d66 into NixOS:staging-next Oct 29, 2024
89 of 92 checks passed
@JohnRTitor JohnRTitor removed the ofborg-internal-error Ofborg encountered an error label Oct 29, 2024
@GaetanLepage GaetanLepage deleted the mission-center branch October 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants