Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cconv: link -liconv on darwin #352512

Merged
merged 1 commit into from
Oct 31, 2024
Merged

cconv: link -liconv on darwin #352512

merged 1 commit into from
Oct 31, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Oct 31, 2024 •
edited
Loading

https://hydra.nixos.org/build/276138753/log/tail

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

emilazy
emilazy approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An attempt was made: https://github.com/xiaoyjy/cconv/blob/e70e168ed0247d8e10947b30c48b03d323412b87/configure.ac#L30-L41

@emilazy emilazy merged commit 5a2dbe9 into NixOS:staging-next Oct 31, 2024
15 of 16 checks passed
@paparodeo paparodeo deleted the cconv-iconv branch October 31, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paparodeo @emilazy