Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: fix gc-related hypellfrob.pyx test failure #352810

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

collares
Copy link
Member

@collares collares commented Nov 1, 2024

The following is supposed to be an intermittent failure depending on when the Python GC runs, but it is happening very often on CI, both on x86_64-linux and on aarch64-linux.

sage -t --long --random-seed=117549725075878326137444096744237283023 /nix/store/ml7lj6avy06nayljdmykibx331hkqdgd-sage-src-10.4/src/sage/schemes/cyclic_covers/cycliccover_finite_field.py
**********************************************************************
File "/nix/store/ml7lj6avy06nayljdmykibx331hkqdgd-sage-src-10.4/src/sage/schemes/cyclic_covers/cycliccover_finite_field.py", line 1203, in sage.schemes.cyclic_covers.cycliccover_finite_field.CyclicCover_finite_field.frobenius_polynomial
Failed example:
    CyclicCover(5, x^5 + x).frobenius_polynomial()  # long time
[...]
      File "sage/schemes/hyperelliptic_curves/hypellfrob.pyx", line 129, in sage.schemes.hyperelliptic_curves.hypellfrob.interval_products (build/cythonized/sage/schemes/hyperelliptic_curves/hypellfrob.cpp:7112)
        sig_on()
    SystemError: calling remove_from_pari_stack() inside sig_on()

I'm not exactly sure why the uptick (cypari2 update?), but let's just patch it by importing sagemath/sage#38628.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@collares collares merged commit 2a1725e into NixOS:master Nov 1, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant