Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.gradio: add relaxed aiofiles and markupsafe deps #352853

Closed
wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Nov 1, 2024

Relax the aiofiles and markupsafe deps for the gradio package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tobim
Copy link
Contributor

tobim commented Nov 1, 2024

These were pinned in gradio-app/gradio#4885 to prevent gradio apps from breaking.
Relaxing the deps reintroduces this issue. I suppose that is better than keeping a broken build, but making the correct major versions available would arguably be the better solution.

@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 1, 2024

Ok, then I would propose that this breakage doesn't block the arrow upgrapde.

@pbsds
Copy link
Member

pbsds commented Nov 2, 2024

done in #352893

@pbsds pbsds closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants