portmod: 2.6.2 -> 2.8.0 #353324

marius851000 · 2024-11-03T09:58:32Z

Things done

Updated to 2.8.0, and adapted change for the fact it now fetch some binaries (and their deps) from it’s own repo.

portmod-gui doesn’t work (but presumably didn’t previously too). This might be the subject of another PR.

I see there is another already opened PR regarding this: #353046
only tried with openmw. I’ll update this PR with some idea from there. And make it run on my hydra. And update my hydra for portmod package CI ( at https://hydra.mariusdavid.fr/jobset/portmod/openmw-mods )

Add a 👍 reaction to pull requests you find important.

zimward

Maybe we could also move this package to by-name

pkgs/games/portmod/default.nix

marius851000 · 2024-11-06T18:52:14Z

@zimward regardig moving it to treewide, wasn’t it supposed to be an automated process? Or has the green light been given for manually moving it?

gepbird · 2024-11-15T22:40:44Z

@zimward regardig moving it to treewide, wasn’t it supposed to be an automated process? Or has the green light been given for manually moving it?

@marius851000 Recently some progress was made on this and ~50% of the packages have been migrated in #354531. Please rebase to fix the merge conflict.

Co-authored-by: ジムワルド <96021122+zimward@users.noreply.github.com>

gepbird

Changes lgtm, builds on x86_64-linux and portmod binary works, thanks!

ZHF: #352882

gepbird · 2024-11-16T09:47:46Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353324

`x86_64-linux`

✅ 2 packages built:

portmod
portmod.dist

LennyPenny · 2024-11-19T15:39:46Z

✔️ Result of nixpkgs-review pr 353324 run on x86_64-linux 1

2 packages built:

portmod
portmod.dist

nixos-discourse · 2024-11-20T17:48:27Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4866

LennyPenny · 2024-11-21T00:30:59Z

Actually I'm getting an error when imagemagick is needed (I see it got removed as a dependency in the package here)

>>> Unpacking package…
>>> Unpacking bittercoastsounds.zip
>>> Unpacking bcsounds-umopp-3.2.0.2.tar.xz
>>> Preparing source in "/tmp/portmod/media-audio/bitter-coast-sounds-1.0/work/bittercoastsounds"…
INFO Applying patch /tmp/portmod/media-audio/bitter-coast-sounds-1.0/work/bcsounds-umopp-3.2.0.2/bcsounds-patch.yaml to bcsounds.esp
Could not start dynamically linked executable: magick
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
Traceback (most recent call last):
  File "/home/lenny/.local/share/portmod/repos/openmw/media-audio/bitter-coast-sounds/bitter-coast-sounds-1.0-r3.pybuild", line 41, in src_prepare
    self.execute("magick convert Textures/Photodragon.tga Textures/Photodragon.dds")
  File "/nix/store/3phz01ydhpjdwala2zm2k0ci4qdjvvg3-portmod-2.8.0/lib/python3.12/site-packages/portmodlib/execute.py", line 34, in execute
    proc = subprocess.run(  # nosec B603
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/901c80rlps5q05bnjk1sj4zaz5k736nc-python3-3.12.7/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['magick', 'convert', 'Textures/Photodragon.tga', 'Textures/Photodragon.dds']' returned non-zero exit status 127.
Successfully merged 9 packages before failure.
Error occurred when attempting to merge media-audio/bitter-coast-sounds-1.0-r3::openmw
ERROR: The prepare phase of the pybuild /home/lenny/.local/share/portmod/repos/openmw/media-audio/bitter-coast-sounds/bitter-coast-sounds-1.0-r3.pybuild failed.
Do not report this error message by itself. There will be another error message from the sandboxed code for the actual problem, probably directly above this one.

FliegendeWurst · 2024-12-14T08:51:44Z

pkgs/by-name/po/portmod/package.nix

@@ -38,14 +43,21 @@ let
    bubblewrap
    git
    python3Packages.virtualenv
-    tr-patcher
-    tes3cmd
-    imagemagick


Still required #353324 (comment)

FliegendeWurst · 2024-12-14T08:52:14Z

pkgs/by-name/po/portmod/package.nix

  '';

-  meta = with lib; {
+  meta = {
    description = "mod manager for openMW based on portage";


Suggested change

description = "mod manager for openMW based on portage";

description = "Mod manager for OpenMW based on portage";

gbtb · 2025-01-11T17:27:02Z

Actually I'm getting an error when imagemagick is needed (I see it got removed as a dependency in the package here)

>>> Unpacking package…
>>> Unpacking bittercoastsounds.zip
>>> Unpacking bcsounds-umopp-3.2.0.2.tar.xz
>>> Preparing source in "/tmp/portmod/media-audio/bitter-coast-sounds-1.0/work/bittercoastsounds"…
INFO Applying patch /tmp/portmod/media-audio/bitter-coast-sounds-1.0/work/bcsounds-umopp-3.2.0.2/bcsounds-patch.yaml to bcsounds.esp
Could not start dynamically linked executable: magick
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld
Traceback (most recent call last):
  File "/home/lenny/.local/share/portmod/repos/openmw/media-audio/bitter-coast-sounds/bitter-coast-sounds-1.0-r3.pybuild", line 41, in src_prepare
    self.execute("magick convert Textures/Photodragon.tga Textures/Photodragon.dds")
  File "/nix/store/3phz01ydhpjdwala2zm2k0ci4qdjvvg3-portmod-2.8.0/lib/python3.12/site-packages/portmodlib/execute.py", line 34, in execute
    proc = subprocess.run(  # nosec B603
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/901c80rlps5q05bnjk1sj4zaz5k736nc-python3-3.12.7/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['magick', 'convert', 'Textures/Photodragon.tga', 'Textures/Photodragon.dds']' returned non-zero exit status 127.
Successfully merged 9 packages before failure.
Error occurred when attempting to merge media-audio/bitter-coast-sounds-1.0-r3::openmw
ERROR: The prepare phase of the pybuild /home/lenny/.local/share/portmod/repos/openmw/media-audio/bitter-coast-sounds/bitter-coast-sounds-1.0-r3.pybuild failed.
Do not report this error message by itself. There will be another error message from the sandboxed code for the actual problem, probably directly above this one.

@LennyPenny Did it work for you on a previous version of portmod? As far as I remember, when I tried to use portmod couple of years ago, the problem with bundled imagemagick was present already, and I had to manually delete it from portmod prefix to unblock myself.
I opened an issue upstream, and hopefully soon more idiomatic solution to force usage of system-provided imagemagick will be added to portmod repository.

marius851000 mentioned this pull request Nov 3, 2024

Update request: portmod 2.6.2 → 2.8.0 #353250

Open

1 task

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 3, 2024

zimward reviewed Nov 4, 2024

View reviewed changes

pkgs/games/portmod/default.nix Outdated Show resolved Hide resolved

zimward added the 8.has: package (update) This PR updates a package to a newer version label Nov 4, 2024

zimward mentioned this pull request Nov 4, 2024

Portmod does not build mods for Fallout: New Vegas. #197624

Open

marius851000 force-pushed the portmod280 branch from 19a53fc to bfb69b6 Compare November 4, 2024 19:07

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024

marius851000 and others added 3 commits November 16, 2024 10:04

portmod: 2.6.2 -> 2.8.0, fixed some other issue

3ea44ab

openmw: Add workaround for not detecting the openmw version

66f2b5f

portmod: nixfmt + add mainProgram + remove with lib;

1b84cda

Co-authored-by: ジムワルド <96021122+zimward@users.noreply.github.com>

marius851000 force-pushed the portmod280 branch from bfb69b6 to 1b84cda Compare November 16, 2024 09:09

gepbird removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 16, 2024

gepbird approved these changes Nov 16, 2024

View reviewed changes

gepbird added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 16, 2024

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024

LennyPenny approved these changes Nov 19, 2024

View reviewed changes

wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 19, 2024

FliegendeWurst requested changes Dec 14, 2024

View reviewed changes

FliegendeWurst added the 2.status: needs-changes This PR needs changes by the author label Dec 14, 2024

Scrumplex mentioned this pull request Dec 29, 2024

patool: 2.4.0 -> 3.1.0 #368882

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

portmod: 2.6.2 -> 2.8.0 #353324

portmod: 2.6.2 -> 2.8.0 #353324

marius851000 commented Nov 3, 2024 •

edited

Loading

zimward left a comment

marius851000 commented Nov 6, 2024

gepbird commented Nov 15, 2024

gepbird left a comment

gepbird commented Nov 16, 2024

LennyPenny commented Nov 19, 2024

nixos-discourse commented Nov 20, 2024

LennyPenny commented Nov 21, 2024 •

edited

Loading

FliegendeWurst Dec 14, 2024

FliegendeWurst Dec 14, 2024

gbtb commented Jan 11, 2025 •

edited

Loading

	description = "mod manager for openMW based on portage";
	description = "Mod manager for OpenMW based on portage";

portmod: 2.6.2 -> 2.8.0 #353324

Are you sure you want to change the base?

portmod: 2.6.2 -> 2.8.0 #353324

Conversation

marius851000 commented Nov 3, 2024 • edited Loading

Things done

zimward left a comment

Choose a reason for hiding this comment

marius851000 commented Nov 6, 2024

gepbird commented Nov 15, 2024

gepbird left a comment

Choose a reason for hiding this comment

gepbird commented Nov 16, 2024

nixpkgs-review result

x86_64-linux

LennyPenny commented Nov 19, 2024

nixos-discourse commented Nov 20, 2024

LennyPenny commented Nov 21, 2024 • edited Loading

FliegendeWurst Dec 14, 2024

Choose a reason for hiding this comment

FliegendeWurst Dec 14, 2024

Choose a reason for hiding this comment

gbtb commented Jan 11, 2025 • edited Loading

marius851000 commented Nov 3, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

LennyPenny commented Nov 21, 2024 •

edited

Loading

gbtb commented Jan 11, 2025 •

edited

Loading