Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.blink-cmp: 0.5.0 -> 0.5.1 #353703

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Balssh
Copy link
Contributor

@Balssh Balssh commented Nov 4, 2024

Things done

Updated blink-cmp version to 0.5.1

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teto
Copy link
Member

teto commented Nov 4, 2024

is there a way to quickly test this ? aka start neovim with completopt set to a function from blink ?

@Balssh
Copy link
Contributor Author

Balssh commented Nov 4, 2024

You mean test it locally?

@mrcjkb
Copy link
Member

mrcjkb commented Nov 5, 2024

is there a way to quickly test this ? aka start neovim with completopt set to a function from blink ?

It appears the plugin uses a setup function, so I don't think a test with completeopt would work.
I'm planning on packaging this for luarocks, so we could potentially add a simple test suite to the plugin itself.

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin has a rust dependency, so someone should probably run nixpkgs-review on both Linux and Darwin.
cc @GaetanLepage (sorry for the ping, I haven't set up the community builders yet 🥲)

@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353703


x86_64-linux

✅ 2 packages built:
  • vimPlugins.blink-cmp
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.blink-cmp
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.blink-cmp
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.blink-cmp
  • vimPluginsUpdater

@ofborg ofborg bot requested a review from redxtech November 5, 2024 06:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 5, 2024
@GaetanLepage
Copy link
Contributor

(sorry for the ping, I haven't set up the community builders yet 🥲)

No worry ! Feel free to ping me for this kind of things :)

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@GaetanLepage GaetanLepage merged commit a5a9321 into NixOS:master Nov 5, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants