Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] edk2: fix subhook submodule URL #354193

Merged

Conversation

mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Nov 7, 2024

Description of changes

The URL of the subhook submodule has changed, as the original repository is no longer available.
tianocore/edk2#6398

fixes #353769

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The URL of the subhook submodule has changed, as the original repository is no longer available.
tianocore/edk2#6398

fixes NixOS#353769
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 7, 2024
@adamcstephens
Copy link
Contributor

Shouldn’t we just backport #353800 ?

@mjoerg
Copy link
Contributor Author

mjoerg commented Nov 7, 2024

Shouldn’t we just backport #353800 ?

Do we want to update from 202402 to 202408 on this channel?

@adamcstephens
Copy link
Contributor

Ahh, no of course not.

@adamcstephens adamcstephens merged commit 341fc85 into NixOS:release-24.05 Nov 7, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants