-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xcodes: 1.5.0 -> 1.6.0, move to by name
, with lib;
cleanup, RFC format
#354932
Conversation
by
name,
with lib;` cleanup, RFC formatby name
, with lib;
cleanup, RFC format
This doesn’t build for me on |
@emilazy not entirely sure, but I think it flown below the radar because Swift didn't build on Hydra for a long time, and so did the packages that depend on it? https://hydra.nixos.org/job/nixpkgs/trunk/xcodes.x86_64-darwin#tabs-status The error is the following:
Not familiar with the internals of Clang/LLVM, but it sounds like it's trying to use an unsupported type ( |
Oh, the problem is that you have to use the Swift |
fbf83eb
to
8cb9553
Compare
@emilazy works, thanks! |
pkgs/by-name/xc/xcodes/package.nix
Outdated
}: | ||
let | ||
generated = swiftpm2nix.helpers ./generated; | ||
stdenv = swift.stdenv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure if this is any different from swiftPackages.stdenv
but I think the latter is canonical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Searched on the repo, and you're right - it seems to be more widely adopted.
Just pushed this change, thanks!
8cb9553
to
eee079f
Compare
Fixes #352844 .
Also:
pkgs/by-name
(whilst adopting the new implicitapple-sdk
pattern)with lib;
usage inmeta
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.