-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin{,-web}: 10.10.1 → 10.10.2 → 10.10.3 #356897
base: master
Are you sure you want to change the base?
Conversation
2bf0366
to
ea6b43f
Compare
To test: # Fetch dotnet updates
git fetch https://github.com/corngood/nixpkgs dotnet-next
git checkout FETCH_HEAD
# [OPTIONAL] Rebase on top of trunk
git fetch https://github.com/nixos/nixpkgs master
git rebase FETCH_HEAD
# (Optionally, instead you could do:)
# git checkout <whatever branch you want>
# git fetch https://github.com/corngood/nixpkgs dotnet-next
# git cherry-pick upstream/master..FETCH_HEAD
# Cherry-pick Jellyfin update commit
git fetch https://github.com/vikanezrimaya/nixpkgs jellyfin-10.10.2
git cherry-pick FETCH_HEAD
# Build
nix build .#jellyfin |
ea6b43f
to
4545329
Compare
Dependent pull request was merged, this is ready for review now. |
Looks good, thanks. Jellyfin 10.10.3 was released recently, could you update your PR? |
@minijackson done! should I squash, or leave two commits sequentially updating the version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Tested by building the smoke-test
, and running the smoke-test interactively for a few minutes.
Result of nixpkgs-review pr 356897
run on x86_64-linux 1
2 packages built:
- jellyfin
- jellyfin-web
@vikanezrimaya I think either is fine, you can leave it as is. |
Resolves #356716. Requires .NET SDK update, therefore depends on aa319c6 (part of #355753)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.