Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin{,-web}: 10.10.1 → 10.10.2 → 10.10.3 #356897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vikanezrimaya
Copy link
Member

@vikanezrimaya vikanezrimaya commented Nov 18, 2024

Resolves #356716. Requires .NET SDK update, therefore depends on aa319c6 (part of #355753)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vikanezrimaya
Copy link
Member Author

vikanezrimaya commented Nov 18, 2024

To test:

# Fetch dotnet updates
git fetch https://github.com/corngood/nixpkgs dotnet-next
git checkout FETCH_HEAD
# [OPTIONAL] Rebase on top of trunk
git fetch https://github.com/nixos/nixpkgs master
git rebase FETCH_HEAD

# (Optionally, instead you could do:)
# git checkout <whatever branch you want>
# git fetch https://github.com/corngood/nixpkgs dotnet-next
# git cherry-pick upstream/master..FETCH_HEAD

# Cherry-pick Jellyfin update commit
git fetch https://github.com/vikanezrimaya/nixpkgs jellyfin-10.10.2
git cherry-pick FETCH_HEAD
# Build
nix build .#jellyfin

@vikanezrimaya vikanezrimaya marked this pull request as ready for review November 19, 2024 10:34
@vikanezrimaya
Copy link
Member Author

Dependent pull request was merged, this is ready for review now.

@minijackson
Copy link
Member

Looks good, thanks. Jellyfin 10.10.3 was released recently, could you update your PR?

@minijackson minijackson added the backport release-24.11 Backport PR automatically label Nov 22, 2024
@vikanezrimaya
Copy link
Member Author

@minijackson done! should I squash, or leave two commits sequentially updating the version?

@vikanezrimaya vikanezrimaya changed the title jellyfin{,-web}: 10.10.1 → 10.10.2 jellyfin{,-web}: 10.10.1 → 10.10.2 → 10.10.3 Nov 22, 2024
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Tested by building the smoke-test, and running the smoke-test interactively for a few minutes.


Result of nixpkgs-review pr 356897 run on x86_64-linux 1

2 packages built:
  • jellyfin
  • jellyfin-web

@minijackson
Copy link
Member

should I squash, or leave two commits sequentially updating the version?

@vikanezrimaya I think either is fine, you can leave it as is.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: jellyfin{,-web} 10.10.1 → 10.10.2
3 participants