qqsp: init at 1.9, qsp: init at 0-unstable-2024-11-27 #363124
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
JohnMolotov
force-pushed
the
qsp
branch
2 times, most recently
from
cb21543 to
d44be07
Compare
ofborg
bot
added
8.has: package (new)
donovanglover
changed the title
pluiedev
suggested changes
Dec 17, 2024
pkgs/by-name/qq/qqsp/package.nix
Outdated
| fetchgit, | ||
| qt5, | ||
| }: | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation (finalAttrs: { |
There was a problem hiding this comment.
Related to this, is stdenv.mkDerivation correct for QT apps? It seems to work, but I've seen various references to "qt5.callPackage"
pluiedev
suggested changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the QSP Library and a QuestSoft Player for QT. Used to play videogames made in the QuestSoft engine.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.