nushellPlugins.hcl: init at 0.100.0 #363512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
Yethal
force-pushed
the
nushellPlugins-port-scan
branch
2 times, most recently
from
9a67785 to
f2d104f
Compare
Yethal
force-pushed
the
nushellPlugins-port-scan
branch
3 times, most recently
from
2283291 to
8b3adb2
Compare
Yethal
force-pushed
the
nushellPlugins-port-scan
branch
from
8b3adb2 to
75a6e4f
Compare
github-actions
bot
added
10.rebuild-darwin: 0
|
@Kamillaova sorry to tag you again, I'm still unable to request review via GitHub UI. I reopened the PR because it was easier than struggling with amending commits after rebase. |
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4946 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5090 |
PerchunPak
suggested changes
Jan 15, 2025
There was a problem hiding this comment.
Please move formatting changes to a separate commit so it is easier to review
| updateScript = nix-update-script { }; | ||
| }; | ||
|
|
||
| meta = with lib; { |
|
Also, please rebase. It seems like there are some problems with CI and I can't run nixpkgs-review because of them |
Co-authored-by: Perchun Pak <github@perchun.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package for nu_plugin_hcl.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.