Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sewn: init at 0-unstable-2024-11-10 #369971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wintermute-cell
Copy link

This PR simply packages https://codeberg.org/sewn/dam (a minimal status bar for the wayland window manager river) for nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 1, 2025

stdenv.mkDerivation {
pname = "dam";
version = "0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0";
version = "0-unstable-11-10";

];

meta = with lib; {
description = "Itsy-bitsy dwm-esque bar for river.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Itsy-bitsy dwm-esque bar for river.";
description = "Itsy-bitsy dwm-esque bar for river";

"PREFIX=${placeholder "out"}"
];

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wintermute-cell
Copy link
Author

did the suggested changes, thanks @aucub @Sigmanificient

@wintermute-cell wintermute-cell changed the title sewn: init at 0 (unversioned) sewn: init at 0-unstable-2024-11-10 Jan 2, 2025
homepage = "https://codeberg.org/sewn/dam";
license = lib.licenses.mit;
platforms = lib.platforms.linux;
maintainers = with lib.maintainers; [ "sewn" "wintermute-cell" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing due to meta.maintainers that requires a list of maintainers defined within the maintainers/maintainers-list.nix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I think I got how the maintainers field works now!

sewn: init at 0 (unversioned)
@wintermute-cell
Copy link
Author

Not sure what's wrong now. It still seems to be a problem regarding the meta.maintainters, but only on the linux outpaths check:

error: evaluation aborted with the following error message: 'Failed to evaluate dam-0-unstable-2024-11-10: «unknown-meta»: has an invalid meta attrset:
  - key 'meta.maintainers' has invalid value; expected listOf<attrsOf<any>>, got
    [
      "winterveil"
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants