treewide: drop darwinMinVersionHook for macOS < 11
#370693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-owners
bot
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
github-actions
bot
added
10.rebuild-darwin: 501-1000
10.rebuild-linux: 0
nix-owners
bot
requested review from
abbradar,
AndersonTorres,
bkchr,
dduan,
gador,
JoshuaFern,
kmatasfp,
matthewbauer,
niklaskorz,
OPNA2608 and
periklis
|
Okay, 796 might be a bit much with what we’ve already merged so far. I’ll split off the larger rebuilds into a |
khaneliman
reviewed
Jan 3, 2025
wegank
added
the
12.approvals: 1
kmatasfp
reviewed
Jan 3, 2025
wegank
added
12.approved-by: package-maintainer
|
✅ for golem. @GaetanLepage thanks for verifying 🙏 |
|
✅ for Also confirmed working with |
13 tasks
|
@emilazy We good with rebuild count here to merge? |
|
Nah I need to split out some of this to a |
|
emilazy
force-pushed
the
push-lspomqttqkxv
branch
from
6cbb97f to
793706e
Compare
13 tasks
github-actions
bot
added
10.rebuild-darwin: 101-500
and removed
10.rebuild-darwin: 501-1000
labels
|
|
I’m not sure why you ran Please don’t use the community builders as a replacement ofborg to Anyway I’ll get back to these PRs once that’s done. |
You are right. Sorry... Even lowering |
|
Managed to finally get a review through. Looks like no regressions with the sandbox off. I had to skip the .NET packages as they really didn’t want to build for whatever reason, but as they’re just downstream from Swift it should be fine. (Really this probably only needed packages that were directly touched building; I should implement the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #370445 and friends. Time to resurrect my big old branch for a lot of the remaining stuff…
Running a
nixpkgs-review, just in case. I think this is small enough formasterbut I can move the Qt change tostagingif desired.cc @ofalvai @niklaskorz @kmatasfp for the
apple-sdk_15unpins; it didn’t seem like those packages actually used any functionality newer than macOS 11, but I could be wrong.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.