Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove obsolete Darwin patches #371539

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jan 6, 2025

These no longer apply and shouldn’t be necessary with the new SDK pattern.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 6, 2025
These no longer apply and shouldn’t be necessary with the new
SDK pattern.
@emilazy emilazy force-pushed the push-nwznnrpxwutz branch from 5a1ca9c to a3d56f6 Compare January 6, 2025 20:12
@nix-owners nix-owners bot requested review from LnL7 and ttuegel January 6, 2025 20:16
@emilazy emilazy marked this pull request as ready for review January 6, 2025 20:28
@emilazy emilazy merged commit a179678 into NixOS:staging-next Jan 6, 2025
25 of 29 checks passed
@emilazy emilazy deleted the push-nwznnrpxwutz branch January 6, 2025 20:30
@bendlas bendlas mentioned this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant