Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] gnupg: fix cross #371542

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

yuyuyureka
Copy link
Contributor

@yuyuyureka yuyuyureka commented Jan 6, 2025

Broken since #352434
Fixes pkgsCross.armv7l-hf-multiplatform.gnupg

libgpg-error is both buildInput iand nativeBuildInput

Change-Id: Iec2f19ee770fb66aedaa444c16ebf3091b04bcef

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

libgpg-error is both buildInput iand nativeBuildInput

Change-Id: Iec2f19ee770fb66aedaa444c16ebf3091b04bcef
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 6, 2025
@yuyuyureka yuyuyureka changed the title gnupg: fix cross [staging-next] gnupg: fix cross Jan 6, 2025
@nix-owners nix-owners bot requested review from fpletz and stigtsp January 6, 2025 20:22
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilazy emilazy merged commit aaefb9b into NixOS:staging-next Jan 6, 2025
48 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 101-500 10.rebuild-linux: 5001+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants