Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rzls: init at 9.0.0-preview.25052.3 #371569

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rzls: init at 9.0.0-preview.25052.3 #371569

wants to merge 2 commits into from

Conversation

bretek
Copy link
Member

@bretek bretek commented Jan 6, 2025 •
edited
Loading

Fix #369979

Output can be seen by running rzls --debug. Otherwise no output is shown unless connected to a language server handler. I've tested with neovim and the rzls.nvim plugin.

Added update script.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 6, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 6, 2025
@bretek bretek mentioned this pull request Jan 6, 2025
Merged
13 tasks
@tris203 tris203 mentioned this pull request Jan 7, 2025
Closed
13 tasks
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from ea06bd0 to ab6f389 Compare January 8, 2025 21:47
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 8, 2025
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from ab6f389 to 9ab288d Compare January 8, 2025 21:50
@bretek bretek changed the title Rzls init at 9.0.0-preview.24605.1 Rzls init at 9.0.0-preview.25052.3 Jan 8, 2025
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from 9ab288d to 09e2150 Compare January 9, 2025 07:03
@tris203
Copy link

tris203 commented Jan 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371569

x86_64-linux

✅ 1 package built:
  • rzls

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 9, 2025
@l1npengtul
Copy link
Contributor

Just remember to run nixfmt again and we should be good

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 9, 2025
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from 09e2150 to 66cf9c8 Compare January 9, 2025 23:02
@l1npengtul l1npengtul added the 8.has: package (new) This PR adds a new package label Jan 9, 2025
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 10, 2025
@bretek
Copy link
Member Author

bretek commented Jan 11, 2025

Just remember to run nixfmt again and we should be good

Ran nixfmt, checks now pass

@bretek bretek requested a review from l1npengtul January 11, 2025 11:09
l1npengtul
l1npengtul approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@l1npengtul l1npengtul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats, and good work!

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 11, 2025
@tris203
Copy link

tris203 commented Jan 13, 2025

@corngood is there any chance you could look at this one too as it goes hand in hand with #373293

@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from 66cf9c8 to ce2649d Compare January 14, 2025 21:33
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch 2 times, most recently from 4a47e88 to cc7bed6 Compare January 15, 2025 20:50
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 15, 2025
@FliegendeWurst FliegendeWurst changed the title Rzls init at 9.0.0-preview.25052.3 rzls: init at 9.0.0-preview.25052.3 Jan 15, 2025
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch 2 times, most recently from 7d570a9 to 142bff5 Compare January 16, 2025 23:57
@bretek bretek force-pushed the rzls-init-9.0.0-preview.24605.1 branch from 142bff5 to a058588 Compare January 17, 2025 16:31
@corngood
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371569

x86_64-linux

✅ 1 package built:
  • rzls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l1npengtul l1npengtul l1npengtul approved these changes

@tris203 tris203 tris203 approved these changes

@corngood corngood corngood approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: rzls
6 participants
@bretek @tris203 @l1npengtul @corngood @wegank @NixOSInfra