Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsPackages.gotest-ts: 20241209 -> 20250107 #371772

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Jan 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FliegendeWurst FliegendeWurst changed the title emacsPackages.gotest-ts: fix build emacsPackages.gotest-ts: 20241209 -> 20250107 Jan 8, 2025
@adisbladis adisbladis merged commit ef46055 into NixOS:staging-next Jan 8, 2025
30 of 34 checks passed
@jian-lin
Copy link
Contributor Author

jian-lin commented Jan 8, 2025

@FliegendeWurst Thanks for your review.

This PR is part of a regular bump of Emacs lisp packages: #371120

The point of this PR is to fix build failure instead of bumping again. So I prefer the old PR title. :)

@jian-lin jian-lin deleted the pr/gotest-ts-fix branch January 8, 2025 08:58
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Jan 8, 2025

I'll keep that in mind for next time. Just changed the PR title based on the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: emacs Text editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants