iso-image: include release and system info in iso filenames again #372127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
arianvp
approved these changes
Jan 8, 2025
github-actions
bot
added
10.rebuild-darwin: 0
phaer
changed the title
While switching from isoImage.baseName to the unified image.baseName, I accidentaly dropped label and system information from the iso filename. This fixes it by including isoImage.edition in the default baseName for all our isos. Resulting in filenames such as `nixos-minimal-25.05beta708350.1d95cb5-x86_64-linux.iso` again instead of just nixos-minimal.iso.
phaer
force-pushed
the
fix-iso-filename
branch
from
be1f81b to
0b162c3
Compare
Mindavi
approved these changes
Jan 8, 2025
mweinelt
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix a channel-blocking mistake i made w.r.t. to filenames of generated isoImages in #359345. Thanks @vcunat for reporting and apologies for breaking it!
While switching from isoImage.baseName to the unified image.baseName, I accidentaly dropped label and system information from the iso filename.
This fixes it by including isoImage.edition in the default baseName for all our isos. Resulting in filenames such as
nixos-minimal-25.05beta708350.1d95cb5-x86_64-linux.isoagain instead of just nixos-minimal.iso.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.