-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmuxPlugins.tmux-which-key: init at 0-unstable-2024-06-08 #372455
Conversation
7163bc9
to
f8893b6
Compare
Hmm.. currently running into an issue with getting the plugin to recognize the configuration files (upstream issue); whatever the default configuration it uses works fine but any changes made seems to be ignored by the plugin. |
f8893b6
to
543b649
Compare
Ah so it turned out a home-manager module is needed in order to make changes via the nix way because the package's python script converts the yaml config file into tmux commands during derivation. See: alexwforsythe/tmux-which-key#15 (comment) Also I went and renamed it to match the name of the repository. |
543b649
to
52c72f3
Compare
52c72f3
to
0524349
Compare
@FliegendeWurst Sorry for the delay! I was having some trouble with the package building but I got the issues sorted out. (turned out it was related to the accompanying home-manager module was using the native build inputs, I went and changed it on my local version of the module). |
0524349
to
5963b7d
Compare
5963b7d
to
d5bc05a
Compare
Fixes #367462
Additionally, I add myself as maintainer of the package. I tested basic functionality in my flake (as well built it with
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
) and found that it works correctly.flake info:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.