nixos-build-vm: Remove Nixpkgs path dependency #372492
Conversation
4ce241c switched `substituteAll` for `replaceVars`. The latter stringifies the replacements, which leads to Nixpkgs filesystem path being embedded in the output. This is disallowed by nixpkgs-basic-release-checks.nix. NixOS#371501 (comment)
| replacements = { | ||
| inherit runtimeShell; | ||
| buildVms = ./build-vms.nix; | ||
| buildVms = "${./build-vms.nix}"; | ||
| }; |
There was a problem hiding this comment.
I wonder whether we should fix replaceVars to do that automatically?
There was a problem hiding this comment.
I am split on that, hence just the quick workaround. Especially when it did not look like any other replacement in your PR used paths.
It might be useful to have real file system paths sometimes. Though, I guess one can always use toString in the caller, and derivation does copy paths passed to it to the store, so it might be better to do the same for consistency.
There was a problem hiding this comment.
Especially when it did not look like any other replacement in your PR used paths.
Yes, but I have a few 100 more replacements coming up eventually - the goal is to replace substituteAll entirely. So there might be more paths coming up.
There was a problem hiding this comment.
I originally did toString on the inputs to replaceVars that and was counseled against in in the original replaceVars PR. I'm fine with this quick workaround; let's see if there are other instances like this.
There was a problem hiding this comment.
A quick grep only came up with one other potential candidate:
nixpkgs/pkgs/development/tools/build-managers/gradle/default.nix
Lines 214 to 218 in 3f14b85
4ce241c switched
substituteAllforreplaceVars.The latter stringifies the replacements, which leads to Nixpkgs filesystem path being embedded in the output.
This is disallowed by nixpkgs-basic-release-checks.nix.
#371501 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.