treewide: replace substituteAll with replaceVars (part 3) #373659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the road again, driving #237216 forward. Continuation of #365440. Same approach: Auto-generated changes, removed all of those that would require adjustments.
The number of rebuilds is higher here, so targeting staging. But since this PR only contains changes in
by-name/
, it's easy to generate a build command to target the actually changed packages:I ran this on a checkout of the PR, thus building all touched files. We probably need to double-check that none of the changes are behind a conditional which wouldn't be reached that way.
Edit: I tested this on the merge-base of master and staging, but there was a conflict here for one package. Thus rebased on latest staging - unfortunately, this causes about 3k builds for me now. So probably better tested by applying the changes to master first...
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.