Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.121.1 -> 1.122.0 #373782

Merged
merged 1 commit into from
Jan 16, 2025
Merged

matrix-synapse: 1.121.1 -> 1.122.0 #373782

merged 1 commit into from
Jan 16, 2025

Conversation

sumnerevans
Copy link
Contributor

https://github.com/element-hq/synapse/releases/tag/v1.122.0

Signed-off-by: Sumner Evans me@sumnerevans.com

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

Add macaroon_secret_key_path config option. (element-hq/synapse#17983)

We should add an option for this.

@sumnerevans
Copy link
Contributor Author

@mweinelt settings is already freeform, is there a reason that needs to be added specifically?

@mweinelt
Copy link
Member

Ah right, I forgot.

NickCao
NickCao approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my HS.

Ma27
Ma27 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here as well, would merge tonight.

@Ma27 Ma27 merged commit 5df4362 into NixOS:master Jan 16, 2025
25 of 27 checks passed
@Ma27 Ma27 added the backport release-24.11 Backport PR automatically label Jan 16, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 16, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 16, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@Ma27 Ma27 Ma27 approved these changes

@teutat3s teutat3s Awaiting requested review from teutat3s

@mguentner mguentner Awaiting requested review from mguentner

@Ralith Ralith Awaiting requested review from Ralith

@dali99 dali99 Awaiting requested review from dali99

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumnerevans @mweinelt @Ma27 @NickCao