Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.wandb: 0.18.5 -> 0.19.5 #373808

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jan 14, 2025

Please review whether the newly-disabled tests are important or not.

Closes #365069

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that this is working. I'm seeing this:

============================= test session starts ==============================
platform darwin -- Python 3.12.8, pytest-8.3.3, pluggy-1.5.0 -- /nix/store/8zc3wcplydp8gsxms24scpzdca438dk5-python3-3.12.8/bin/python3.12
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase(PosixPath('/private/tmp/nix-build-python3.12-wandb-0.18.5.drv-0/source/.hypothesis/examples'))
rootdir: /private/tmp/nix-build-python3.12-wandb-0.18.5.drv-0/source
configfile: pyproject.toml
testpaths: tests
plugins: hypothesis-6.112.2, pyfakefs-5.6.0, asyncio-0.23.8, cov-nixpkgs-stub-1.0.0, mock-3.14.0, timeout-2.3.1, xdist-3.6.1, typeguard-4.3.0
asyncio: mode=Mode.AUTO
timeout: 60.0s
timeout method: signal
timeout func_only: False

@FliegendeWurst FliegendeWurst marked this pull request as draft February 2, 2025 21:33
@FliegendeWurst
Copy link
Member Author

Right. It should be pytestFlagsArray. I'll also look into new test failures due to the recent moviepy upgrade #375144.

@FliegendeWurst FliegendeWurst changed the base branch from master to staging-next February 3, 2025 07:29
@FliegendeWurst FliegendeWurst changed the title python312Packages.wandb: increase test timeout python312Packages.wandb: 0.18.5 -> 0.19.5 Feb 3, 2025
@FliegendeWurst FliegendeWurst marked this pull request as ready for review February 3, 2025 07:31
Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, i think this is fine to merge as long as nixpkgs-review looks ok

@SuperSandro2000 SuperSandro2000 merged commit 2c4005e into NixOS:staging-next Feb 3, 2025
53 of 55 checks passed
@samuela
Copy link
Member

samuela commented Feb 3, 2025

@SuperSandro2000 This wasn't supposed to be merged until we had nixpkgs-review done

@SuperSandro2000
Copy link
Member

It is targeting staging-next which has currently lots of build failures related and unrelated. We would have never gotten a full green out of it and we'll take the fix.

@samuela
Copy link
Member

samuela commented Feb 3, 2025

It is targeting staging-next which has currently lots of build failures related and unrelated. We would have never gotten a full green out of it and we'll take the fix.

Ah got it, thought this was targeting master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants