Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] tests.overriding: format with nixfmt-rfc-style and categorize #373959

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[Backport release-24.11] tests.overriding: format with nixfmt-rfc-style and categorize #373959

merged 2 commits into from
Jan 16, 2025

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jan 15, 2025 •
edited
Loading

This PR backports the chore changes of #366583 that format the Nix expression of tests.overriding according to Nix RFC 166 and categorise the test cases according to the build helpers they are testing.

This PR enables automatic backport of subsequent PRs that add new test cases under tests.overriding.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee
tests.overriding: format with nixfmt-rfc-style
1be59a7 
Backport commit 662cf49
@ShamrockLee
tests.overriding: restructure and categorise by test targets
a13513d 
Split tests in the let-in block into
tests-stdenv, tests-go, and tests-python.

Place the dependent variables into the let-in block of each category.

This chore commit causes no rebuilds.

(cherry picked from commit 9e66d6c)
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 15, 2025
@ShamrockLee ShamrockLee merged commit 869634e into NixOS:release-24.11 Jan 16, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@roberth roberth Awaiting requested review from roberth

@infinisil infinisil Awaiting requested review from infinisil

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShamrockLee @wolfgangwalther