Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: Update felbinger #374511

Merged
merged 1 commit into from
Jan 17, 2025
Merged

maintainers: Update felbinger #374511

merged 1 commit into from
Jan 17, 2025

Conversation

felbinger
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 17, 2025
@Adda0 Adda0 added 12.approvals: 1 This PR was reviewed and approved by one reputable person 8.has: maintainer-list (self update) This PR changes PR author's entry in `maintainers/maintainer-list.nix` merge-queue merge after ci succeeds and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 17, 2025
@SuperSandro2000 SuperSandro2000 merged commit e78a020 into NixOS:master Jan 17, 2025
29 of 31 checks passed
@felbinger felbinger deleted the fix-maintainer branch January 17, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adda0 Adda0 Adda0 approved these changes

@Defelo Defelo Defelo approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (self update) This PR changes PR author's entry in `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person merge-queue merge after ci succeeds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felbinger @Defelo @Adda0 @SuperSandro2000