Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/*: cleanup code-escaped manpage urls #379589

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Feb 5, 2025

Cleanup from #377184, made with

rg '[a-zA-Z.-]+\([0-9]+\)' -tnix nixos/ -l | xe sd '`\{manpage\}`([a-zA-Z.-]+\([0-9]+\))``' '{manpage}`$1`'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Done with

    rg '[a-zA-Z.-]+\([0-9]+\)' -tnix nixos/ -l | xe sd '`\{manpage\}`([a-zA-Z.-]+\([0-9]+\))``' '{manpage}`$1`'
@pbsds pbsds marked this pull request as ready for review February 5, 2025 12:23
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 5, 2025
@pbsds pbsds mentioned this pull request Feb 5, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 5, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 5, 2025
@philiptaron philiptaron merged commit b26757f into NixOS:master Feb 8, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants