cc-wrapper, bintools-wrapper: unbreak include/link paths when cross-compiling #41429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
2110c0b refactored
cc-wrapper
andbintools-wrapper
to use pkgs/build-support/setup-hooks/role.bash. There appears to have been a small mistake in how this was done, which caused dependencies to be addedNIX_TARGET_CFLAGS/LDFLAGS
instead ofNIX_CFLAGS/LDFLAGS
when cross-compiling.I discovered this when attempting to cross compile
tmon
, which failed because it was unable to find itsncurses
dependency. With this PR, it successfully compiles.Things done
Use
getHostRoleEnvHook
instead ofgetTargetRoleEnvHook
, which looks at$depHostOffset
instead of$depTargetOffset
.cc @Ericson2314
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)