-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL2: do not propagate private dependencies #41902
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Success on x86_64-linux (full log) Attempted: SDL2 Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failure on x86_64-darwin (full log) Attempted: SDL2 Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
Success on aarch64-linux (full log) Attempted: SDL2 Partial log (click to expand)
|
@GrahamcOfBorg build wesnoth |
Success on x86_64-linux (full log) Attempted: wesnoth Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: wesnoth Partial log (click to expand)
|
Yep, this LGTM. Should we do the same for SDL1? |
This prevents future rebuilds on Darwin if this Linux-only postFixup changes.
There are two symlinks pointing to the same library, libSDL2.so and libSDL2-2.0.so.0. patchelf should run on non-symlinks instead.
Fixes NixOS#41620 by adding libGL directory to libSDL2 runpath
Yes, that would be right. |
This package depends on qtmultimedia which depends on libpulse whose libtool files add `-lcap` to the linker command line. These libtool files should be stripped with pruneLibtoolFiles, and then libcap dependency can be removed.
Thanks for unblocking this and sorry for failing to act before :/ |
Motivation for this change
This uses
pruneLibtoolFiles
from #41819 to avoid the need to propagate private dependencies to dependent packages.Fixes #41620 by adding libGL directory to libSDL2 runpath.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)Tested compilation of some dependent packages on NixOS and macOS.
/cc @cpages as the maintainer, @oxij as the author of the previous refactoring.